This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/7 v2] Pull out common parts of _initialize_{i386,amd64}_linux_nat

From: Pedro Alves <palves at redhat dot com>
To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Date: Wed, 09 Jul 2014 14:09:26 +0100
Subject: Re: [PATCH 4/7 v2] Pull out common parts of _initialize_{i386,amd64}_linux_nat
Authentication-results: sourceware.org; auth=none
References: <1403878351-22974-1-git-send-email-gbenson at redhat dot com> <1403878351-22974-5-git-send-email-gbenson at redhat dot com>

I think I'd prefer s/x86_linux_register_target/x86_linux_add_target,
as we use "add" everywhere else related, like in add_target/linux_nat_add_target.

Otherwise looks good to me.

Thanks,
-- 
Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]