This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Align behavior of xmethod commands with that of pretty-printer commands
- From: Doug Evans <dje at google dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>
- Date: Fri, 20 Jun 2014 22:30:16 +0200
- Subject: Re: [PATCH] Align behavior of xmethod commands with that of pretty-printer commands
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gxz_6KcRsu8iFZ9WXfeS5zQb+gf=dfwsv89_US=uqS5tQ at mail dot gmail dot com>
On Wed, Jun 18, 2014 at 1:55 PM, Siva Chandra <sivachandra@google.com> wrote:
> Currently, the xmethod commands lookup xmethod matchers in the current
> progspace even if the locus regular expression matches the progspace's
> filename. Pretty printer commands do not match the current
> progspace's filename.
>
> I think this should also go into the 7.8 branch.
>
> ChangeLog
>
> 2014-06-18 Siva Chandra Reddy <sivachandra@google.com>
>
> gdb/
>
> * python/lib/gdb/command/xmethods.py
> (get_method_matchers_in_loci): Lookup xmethod matchers in the
> current progspace only if the string "progspace" matches LOCUS_RE.
>
> gdb/testsuite
>
> * gdb.python/py-xmethods.exp: Use "progspace" instead of the
> progspace's filename in 'info', 'enable' and 'disable' command
> tests.
I can't easily test the patch, I'm assuming you've done that.
LGTM otherwise.