This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 14/15] Create nat/i386-dregs.c
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Jun 2014 14:42:53 +0100
- Subject: Re: [PATCH 14/15] Create nat/i386-dregs.c
- Authentication-results: sourceware.org; auth=none
- References: <1403014378-4349-1-git-send-email-gbenson at redhat dot com> <1403014378-4349-15-git-send-email-gbenson at redhat dot com> <53A0731C dot 70202 at redhat dot com>
Pedro Alves wrote:
> Hmm, there's still one remaining difference in gdb vs gdbserver,
> after this, in hw breakpoints.
>
> i386_insert_hw_breakpoint and i386_remove_hw_breakpoint on
> the GDB side still have the "work on a local copy"
> bits, and the i386_dr_update_inferior_debug_regs and
> i386_dr_show calls:
[snip]
>
> While on the gdbserver side, we just call i386_dr_insert_watchpoint:
[snip]
> Any reason GDB can't do the same?
Very good spot!
I'll work on this. It also allows a bunch of those static calls to be
reverted back to nonstatic. I like that (they made the exported
interface of i386-dregs ugly!)
I will work on a series to do this.
Thanks,
Gary
--
http://gbenson.net/