This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
- From: Pierre Langlois <pierre dot langlois at embecosm dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 13 Jun 2014 10:14:19 +0100
- Subject: Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
- Authentication-results: sourceware.org; auth=none
- References: <1402594537-8033-1-git-send-email-pierre dot langlois at embecosm dot com> <5399EEC8 dot 5080904 at redhat dot com>
>> I was wondering how to go about adding a test for this in
>> the GDB testsuite. Could we include faulty dummy servers to test each packets?"
>
> These two sentences shouldn't really be in the commit log.
>
Yes, absolutely. So what would be the usual way of formatting an email with
adding questions to the mix? I realize this out of the scope of the review so
I'll ask on IRC.
>> + chain_before_invalidate_register =
>> + make_cleanup_regcache_invalidate (regcache, regnum);
>
> I missed this before, but '=' goes on the next line, like:
>
> chain_before_invalidate_register
> = make_cleanup_regcache_invalidate (regcache, regnum);
>
> OK with these changes.
>
> Thanks!
>
Thank you for your review! I'll address the last formatting issue and commit it.
Best,
Pierre