This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.


>> I was wondering how to go about adding a test for this in
>> the GDB testsuite. Could we include faulty dummy servers to test each packets?"
> 
> These two sentences shouldn't really be in the commit log.
> 

Yes, absolutely. So what would be the usual way of formatting an email with
adding questions to the mix? I realize this out of the scope of the review so
I'll ask on IRC.

>> +  chain_before_invalidate_register =
>> +    make_cleanup_regcache_invalidate (regcache, regnum);
> 
> I missed this before, but '=' goes on the next line, like:
> 
>   chain_before_invalidate_register
> 	= make_cleanup_regcache_invalidate (regcache, regnum);
> 
> OK with these changes.
> 
> Thanks!
> 

Thank you for your review! I'll address the last formatting issue and commit it.

Best,

Pierre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]