This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
The attached patch fixes PR 17017 along the lines suggested by Pedro here: https://sourceware.org/ml/gdb-patches/2014-06/msg00212.html It does not use get_integer_valueof as suggested by Pedro as he pointed out in his review of v2 that we will then have to enclose some of the tests in with_test_prefix to make the names unique: https://sourceware.org/ml/gdb-patches/2014-06/msg00308.html What I have done in v3 is to use the idea of testing C++ method invocation by testing the value of a global var from Pedro's first suggestion, but tested the value of the global var using gdb_test instead of get_integer_valueof. ChangeLog testsuite/ 2014-06-12 Siva Chandra Reddy <sivachandra@google.com> PR gdb/17017 * gdb.python/py-xmethods.cc: Add global function call counters and increment them in their respective functions. Remove "cout" statements. * gdb.python/py-xmethods.exp: Make tests check the global function call counters instead of depending on inferior IO.
Attachment:
fix_xmethod_failures_v3.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |