This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Delete temporary string within demangler even in failure cases.
- From: Andrew Burgess <aburgess at broadcom dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, <gdb-patches at sourceware dot org>
- Date: Tue, 10 Jun 2014 19:08:53 +0100
- Subject: Re: [PATCH] Delete temporary string within demangler even in failure cases.
- Authentication-results: sourceware.org; auth=none
- References: <1401188253-15214-1-git-send-email-aburgess at broadcom dot com> <CAKOQZ8x4wmbgnkj7YN+iojxN-3fHDrd8fqCLSny31Q=NHzmV6w at mail dot gmail dot com>
On 27/05/2014 2:47 PM, Ian Lance Taylor wrote:
> On Tue, May 27, 2014 at 3:57 AM, Andrew Burgess <aburgess@broadcom.com> wrote:
>>
>> libiberty/ChangeLog
>>
>> * cplus-dem.c (do_type): Call string_delete even if the call to
>> demangle_template fails.
>
> This is OK.
>
> Thanks.
>
> I have to ask: you know this code is not used, right? You're looking
> at the old demangler, for symbols generated by versions of g++ before
> GCC 3.4 (released 2004). The demangler for current versions of g++ is
> in cp-demangle.c.
Sorry for the delay. Yes, I know it's not very old code, but it is
still shipped, and consumers such as gdb can still trigger this code
path.
Thanks for taking a look at this patch for me.
I don't have gcc write permissions, would you (or any other interested
maintainer) mind committing this for me please.
Thanks,
Andrew