This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ping] [PATCH] Different outputs affected by locale
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Thu, 05 Jun 2014 11:27:33 +0100
- Subject: Re: [ping] [PATCH] Different outputs affected by locale
- Authentication-results: sourceware.org; auth=none
- References: <1401192650-29688-1-git-send-email-yao at codesourcery dot com> <538EAEE5 dot 2080708 at codesourcery dot com> <20140604124708 dot GR4289 at adacore dot com> <538F1CC3 dot 9090605 at codesourcery dot com> <87oay8a0t6 dot fsf at fleche dot redhat dot com> <538F803A dot 9020007 at redhat dot com> <538FE412 dot 1050806 at codesourcery dot com> <53903119 dot 6000204 at redhat dot com> <53903EE5 dot 8090107 at codesourcery dot com>
On 06/05/2014 10:56 AM, Yao Qi wrote:
> Yes, it is simple to pass env variable through ssh, but isn't trivial to
> pass env variable to host or target in dejagnu, because,
>
> - ssh is not the only connection dejagnu supports, how about telnet?
Well, nobody really uses that for _host_ connections.
> - env variable should bind to board. host and target can have
> different env vars.
>
> I saw Jie's patch to set env var on target
> http://lists.gnu.org/archive/html/dejagnu/2008-07/msg00000.html
> but we need do more than that, IMO. That is the reason I am inclined to
> fix the test case instead of the infrastructure (dejagnu).
In practice, all real host board files will have a ${board}_spawn
override anyway. We can set GDB's vars in a gdb_env array, similar
to Jie's patch, and then the ${board}_spawn routine can pass them
to $RSH. When/if Jie's patch is extended to bind to board, and
accepted upstream, we just set the appropriate new board var to $gdb_env.
--
Pedro Alves