This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/4] New test for backtrace when the stack pointer is invalid (inaccessible).


On 04/30/2014 11:55 AM, Andrew Burgess wrote:

> +
> +#include <sys/mman.h>
> +#include <unistd.h>
> +#include <assert.h>
> +
> +void
> +breakpt ()

'(void)' here and elsewhere.

> +int
> +main ()

Otherwise looks fine.

(I'd have slightly preferred that the patch
for the crash included the test, adjusted as necessary, and
then the follow up patches added / built on the existing test.)

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]