This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix argument passing in mi_run_cmd_full
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 21 May 2014 09:46:18 +0100
- Subject: Re: [PATCH v2] Fix argument passing in mi_run_cmd_full
- Authentication-results: sourceware.org; auth=none
- References: <1400017636-28020-1-git-send-email-simon dot marchi at ericsson dot com> <87ha4lwobm dot fsf at fleche dot redhat dot com> <537B8561 dot 6010603 at ericsson dot com> <537BD614 dot 5030600 at ericsson dot com>
On 05/20/2014 11:24 PM, Simon Marchi wrote:
> In my opinion, I think the old behavior was fine, it just needs to be documented better (clarify what $args means in the mi_run_* procedures).
I agree, because it's also the simplest, and as you say,
> I ended up not even using this fix, since Pedro suggested that to modify
> the behavior of a test program, I should stop at a breakpoint and modify
> the value of a global variable instead.
nothing is actually making use of the original fix.
If we end up needing to pass program arguments to mi_run_cmd
in MI mode, we can revisit.
Thanks,
--
Pedro Alves