This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [guile] Run finalizers from GDB thread
- From: Doug Evans <xdje42 at gmail dot com>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 26 Apr 2014 13:26:14 -0700
- Subject: Re: [PATCH] [guile] Run finalizers from GDB thread
- Authentication-results: sourceware.org; auth=none
- References: <87sipcqdmo dot fsf at igalia dot com>
Andy Wingo <wingo@igalia.com> writes:
> gdb/ChangeLog:
> * guile/guile.c (_initialize_guile): Disable automatic
> finalization, if Guile offers us that possibility.
>
> * guile/guile.c (call_initialize_gdb_module):
> * guile/scm-safe-call.c (gdbscm_with_catch): Arrange to run
> finalizers in appropriate places.
>
> * configure.ac: Add a check for
> scm_set_automatic_finalization_enabled.
Hi. Ok with a few nits.
1) Since all of these changes are related, don't separate them with
blank lines in the changelog entry.
2) Write the configure.ac entry as:
* configure.ac (AC_TRY_LIBGUILE): Add a check for
scm_set_automatic_finalization_enabled.
3) Include the changelog entry for configure being regenerated, even
though it's not included in the patch:
* configure: Regenerate.
Thanks!