This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] Migrate dw2-ifort-parameter.exp to Dwarf::assemble
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: arnez at linux dot vnet dot ibm dot com (Andreas Arnez)
- Cc: gdb-patches at sourceware dot org, krebbel at linux dot vnet dot ibm dot com (Andreas Krebbel)
- Date: Tue, 11 Mar 2014 15:50:53 +0100 (CET)
- Subject: Re: [PATCH 3/4] Migrate dw2-ifort-parameter.exp to Dwarf::assemble
- Authentication-results: sourceware.org; auth=none
Andreas Arnez wrote:
> A "side effect" of the migration to Dwarf::assemble is that the DWARF
> address size is now automatically adjusted to the target architecture.
> The original assembler source hard-coded the DWARF address size to 4,
> even on 64-bit architectures. This address size mismatch caused a
> test case failure on s390x due to a wrong result from DW_OP_deref.
I agree that this is best way to fix the underlying problem ---
and it's a nice cleanup, too!
> gdb/testsuite/
> * gdb.dwarf2/dw2-ifort-parameter-debug.S: Remove.
> * gdb.dwarf2/dw2-ifort-parameter.exp: Use Dwarf::assemble to
> generate the debug info assembler source.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com