This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 08/15] vla: support for DW_AT_count
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Sanimir Agovic <sanimir dot agovic at intel dot com>
- Cc: tromey at redhat dot com, keven dot boell at intel dot com, gdb-patches at sourceware dot org
- Date: Fri, 28 Feb 2014 08:53:00 -0800
- Subject: Re: [PATCH v5 08/15] vla: support for DW_AT_count
- Authentication-results: sourceware.org; auth=none
- References: <1391704056-25246-1-git-send-email-sanimir dot agovic at intel dot com> <1391704056-25246-9-git-send-email-sanimir dot agovic at intel dot com>
> 2013-11-19 Sanimir Agovic <sanimir.agovic@intel.com>
> Keven Boell <keven.boell@intel.com>
>
> * dwarf2read.c (read_subrange_type): Convert DW_AT_count to a dynamic
> property and store it as the high bound and flag the range accordingly.
> * gdbtypes.c (resolve_dynamic_bounds): If range is flagged as
> RANGE_UPPER_BOUND_IS_COUNT assign low + high - 1 as the new high bound.
> * gdbtypes.h (enum range_flags): New enum.
> (struct range_bounds): Add flags member.
Overall, the patch looks OK to me, but I'd rather we be consistent
with what we've been doing with other type flags, and use a bitfield
instead. I think that'll simplify your patch a bit.
--
Joel