This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior
- From: asmwarrior <asmwarrior at gmail dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Feb 2014 14:11:54 +0800
- Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior
- Authentication-results: sourceware.org; auth=none
- References: <530612A8 dot 4000903 at gmail dot com> <5306A9BC dot 4080701 at codesourcery dot com>
On 2014-2-21 9:19, Yao Qi wrote:
>> gdb/windows-nat.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
>> index a570a1a..b76d94d 100644
>> --- a/gdb/windows-nat.c
>> +++ b/gdb/windows-nat.c
>> @@ -2480,7 +2480,7 @@ windows_xfer_shared_libraries (struct target_ops *ops,
>>
>> obstack_free (&obstack, NULL);
>> *xfered_len = (ULONGEST) len;
>> - return TARGET_XFER_OK;
>> + return len ? TARGET_XFER_OK : TARGET_XFER_EOF;
>> }
>>
>> static enum target_xfer_status
> You still need a changelog entry.
>
Hi, Yao, The change log could be below, fell free to adjust, thanks.
Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed.
The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11.
gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF.
Yuanhui Zhang