Re: [PATCH v2 2/3] remove all_lwps from gdbserver: use list api

[Doug Evans <dje at google dot com>]

On Thu, Feb 20, 2014 at 5:40 AM, Pedro Alves <palves@redhat.com> wrote:
> On 02/19/2014 11:31 PM, Doug Evans wrote:
>> On Thu, Feb 6, 2014 at 4:27 AM, Pedro Alves <palves@redhat.com> wrote:
>>> On 01/29/2014 06:11 PM, Doug Evans wrote:
>
>> Committed with the suggested changes.
>>
>
> Thanks!
>
> (Note that we request contributors to always post what goes into
> the tree, if there were changes since the last post / approval,
> so I think we should get into the habit of doing that ourselves too.)

That's the plan ....
It was getting late and I had a few more things to do.
If there is a < 24(?) hour deadline for such things we'd better write
it down ....

>
>>>> +struct inferior_list_entry *
>>>> +get_first_inferior (void)
>>>> +{
>>>> +  if (all_threads.head != NULL)
>>>> +    return all_threads.head;
>>>
>>> I think this one, being an "inferior" function, should take
>>> a list as argument.
>
> I noticed a little buglet slipped here:
>
> +/* Return a pointer to the first inferior in LIST, or NULL if there isn't one.
> +   This is for cases where the caller needs a thread, but doesn't care
> +   which one.  */
> +
> +struct inferior_list_entry *
> +get_first_inferior (struct inferior_list *list)
> +{
> +  if (all_threads.head != NULL)
> +    return all_threads.head;
>
> Should be:
>
>  if (list->head != NULL)
>    return list->head;

Bleah.