This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method


> > gdb/
> > 2014-02-19  Pedro Alves  <palves@redhat.com>
> > 
> > 	* procfs.c (procfs_target): Don't install procfs_xfer_memory as
> > 	deprecated_xfer_memory hook.
> > 	(procfs_xfer_partial): Call procfs_xfer_memory instead
> > 	of the deprecated_xfer_memory target hook.
> > 	(procfs_xfer_memory): Adjust interface as a to_xfer_partial
> > 	helper.
> 
> FYI: I tried to test it, but the sparc-solaris debugger appears to be
> badly broken at the moment, and I won't have much time left this week
> to investigate the failures, so I'll schedule that for next week.

I forgot to attach a small patch that fixes a build failure because
of a declaration that no longer matches the definition...

After your patch, we could probably avoid the need for this declaration
by swapping two functions, but for another day.

-- 
Joel
>From c4116d749ac04b4c77a25f03c748b6a170cae4e5 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 20 Feb 2014 15:41:34 +0100
Subject: [PATCH] Small fixup.

---
 gdb/procfs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/procfs.c b/gdb/procfs.c
index 0e2112b..8887f10 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -129,7 +129,8 @@ static ptid_t procfs_wait (struct target_ops *,
 			   ptid_t, struct target_waitstatus *, int);
 static enum target_xfer_status procfs_xfer_memory (gdb_byte *,
 						   const gdb_byte *,
-						   ULONGEST, ULONGEST);
+						   ULONGEST, ULONGEST,
+						   ULONGEST *);
 static target_xfer_partial_ftype procfs_xfer_partial;
 
 static int procfs_thread_alive (struct target_ops *ops, ptid_t);
-- 
1.7.10.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]