This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] testsuite: Makefile.in (check-parallel): rm -rf outputs temp.


Hi.

With subsets of tests being easier to run in parallel,
the need to manually clear out the previous run becomes
more important.

I have a wrapper script I generally use to invoke make check
that does "make clean" first, so this generally doesn't trip me up,
but while testing the TESTS=gdb.server/*.exp patch I ran into this.

https://sourceware.org/ml/gdb-patches/2014-02/msg00443.html

testsuite/README says this:
[Thanks Yao for the reminder that this file exists. :-)]

"
GDB_PARALLEL
[...]
To use this mode, set the GDB_PARALLEL on the runtest command line.
Before starting the tests, you must ensure that the directories cache,
outputs, and temp in the test suite build directory are either empty
or have been deleted.  cache in particular is used to share data
across invocations of runtest, and files there may affect the test
results.  Note that the Makefile automatically does these deletions.
"

"make clean" automatically does these deletions, but check-parallel only
automatically deletes "cache".  I can't think of a sufficient reason to not
automagically delete outputs and temp too, at least not by default.

testsuite/README should also mention FORCE_PARALLEL, but that's
a separate patch.

2014-02-13  Doug Evans  <dje@google.com>

	* Makefile.in (check-parallel): rm -rf outputs temp.

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 7a44660..7a6fb00 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -164,7 +164,7 @@ check-single:
 	$(DO_RUNTEST) $(RUNTESTFLAGS)
 
 check-parallel:
-	-rm -rf cache
+	-rm -rf cache outputs temp
 	$(MAKE) -k do-check-parallel; \
 	$(SHELL) $(srcdir)/dg-extract-results.sh \
 	  `find outputs -name gdb.sum -print` > gdb.sum; \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]