This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cleanup: remove declared variables without any references


> Date: Wed, 12 Feb 2014 07:32:34 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > The mipsnbsd-tdep.c one is not ok.  For one thing, you're leaving
> > behind the comment describing the code.  But I think this is better
> > left alone, as somebody might want to add (or put back) the missing
> > glue that uses those bits.
> 
> Hey Mark! The problem with leaving them behind is that they cause
> a build failure when building the HEAD, I think, because we build
> with -Werror. Can we find a way to avoid that? For instance, could
> we #if zero the code?

Probably best to do something like that.  Ideally a NetBSd devloper
would step in and fix things...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]