This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] rl78: vtables are code addresses
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Pedro Alves <palves at redhat dot com>
- Date: Tue, 11 Feb 2014 09:38:20 -0700
- Subject: Re: [RFC] rl78: vtables are code addresses
- Authentication-results: sourceware.org; auth=none
- References: <20140210234449 dot 27faedc6 at redhat dot com> <52F9FE9D dot 6050603 at redhat dot com>
On Tue, 11 Feb 2014 10:42:37 +0000
Pedro Alves <palves@redhat.com> wrote:
> Thus, wouldn't it be a little better to mark the baked in struct
> type as code to begin with?
>
> ---
> gdb/gnu-v3-abi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/gnu-v3-abi.c b/gdb/gnu-v3-abi.c
> index a08dc36..ceccbe5 100644
> --- a/gdb/gnu-v3-abi.c
> +++ b/gdb/gnu-v3-abi.c
> @@ -171,7 +171,7 @@ build_gdb_vtable_type (struct gdbarch *arch)
> TYPE_TAG_NAME (t) = "gdb_gnu_v3_abi_vtable";
> INIT_CPLUS_SPECIFIC (t);
>
> - return t;
> + return make_type_with_address_space (t, TYPE_INSTANCE_FLAG_CODE_SPACE);
> }
>
>
> I believe this makes no difference for archs with flat address space.
> (testing on x86-64 GNU/Linux shows no changes).
Very nice. I've tested your patch and find that it produces
results identical to what I was getting with my patch. Please
check it in...
(Or, if you'd prefer that I check it in, please let me know.)
Thanks!
Kevin