Re: [RFC v2 00/38] clean up target delegation

[Pedro Alves <palves at redhat dot com>]

On 02/06/2014 08:54 PM, Tom Tromey wrote:
> This is revision 2 of the target delegation cleanup series.  The
> original series is here:
> 
>     https://sourceware.org/ml/gdb-patches/2014-01/msg00331.html
> 
> This submission is, again, a squashed version of the series I actually
> developed.  I've redone the squashing using the same patch bundlings
> as before.
> 
> When the time comes, I plan to merge the atomized series rather than
> this one; the squashing having been done to avoid an email flood and
> to bundle the more mechanical patches in an attempt to make reviews
> less strenuous.
> 
> This series differs from the original in several ways, though I
> believe none of the changes are truly major.
> 
> I believe this version addresses all the reviews.
> 
> It required minor changes here and there when I rebased.  I didn't
> generally make a record of these fixes, but they were all simply
> adaptations either to patches that went in earlier, or to other
> patches touching target methods.
> 
> A couple of patches from the old series have already been pushed.
> 
> Patches 33-38 in this series are new to this revision.  They all arose
> from reviews of the first series.  I believe they were all reviewed
> already by Pedro.

There were a couple that we only discussed on internal IRC, I
believe.  FAOD, I've replied to those.

> Built and regtested on x86-64 Fedora 18.  Due to the relatively minor
> nature of the changes from revision 1, I did not redo the more
> comprehensive testing I did of that revision.

I cross checked my previous comments against the new series,
only noticed only a couple small details.  I didn't look again at
patches where in v1 they already looked fine to me.  So to me,
with patches #2 and #4 addressed, this is good to me.  Am I looking
forward to it.

-- 
Pedro Alves