This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix generic address check in gdb.base/dump.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 05 Feb 2014 15:25:33 +0000
- Subject: Re: [PATCH] Fix generic address check in gdb.base/dump.exp
- Authentication-results: sourceware.org; auth=none
- References: <201402051324 dot s15DOR24007610 at glazunov dot sibelius dot xs4all dot nl>
On 02/05/2014 01:24 PM, Mark Kettenis wrote:
> Moves the check until after the inferior has been started such that we
> get the right result for PIEs (position independent executables). The
> addresses of the unrelocated executable tend to be small, but
> relocation is likely to move them above the 4GB boundary.
Doesn't that mean that the set of ran tests potentially
changes depending on the whim of the loader? A more robust
change would disable PIE, similarly to how we pass -Wl,-taso
on alpha, IMO.
>
> ok?
Fine with me, but ...
> 2014-02-05 Mark Kettenis <kettenis@gnu.org>
>
> * gdb.base/dump.exp: Move the generic data address to set
> is64bitonly after starting the inferior to get the correct outcome
> for PIEs.
... I think this "why" remark should be a note in the test itself.
Something like: "Note we check this only after starting the inferior
to get the correct outcome for PIEs.".
Thanks,
--
Pedro Alves