This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] ada-lang.c: Really include "ui-out.h".


Hello,

Currently, ada-lang.c pretends to include "ui-out.h" as follow:

    #ifdef UI_OUT
    #include "ui-out.h"
    #endif

However, UI_OUT is never defined as far as I can tell. This is confirmed
by rebuilding with a #error pragma inside the #ifdef UI_OUT block,
which never triggers.

Since this unit makes references to declarations from ui-out.h,
this patch simply removes the #ifdef/#endif condition.  This has not
been an error so far because "ui-out.h" indirectly gets included,
via one of the other .h files being included.

gdb/ChangeLog:

        * ada-lang.c: Remove "#ifdef UI_OUT" condition for including
        "ui-out.h".

Tested on x86_64-linux, pushed.

Thanks,
-- 
Joel

---
 gdb/ChangeLog  | 5 +++++
 gdb/ada-lang.c | 2 --
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6cedbd9..c949c02 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2014-01-27  Joel Brobecker  <brobecker@adacore.com>
 
+	* ada-lang.c: Remove "#ifdef UI_OUT" condition for including
+	"ui-out.h".
+
+2014-01-27  Joel Brobecker  <brobecker@adacore.com>
+
 	* ada-typeprint (type_is_full_subrange_of_target_type):
 	New function.
 	(print_range): Add parameter bounds_prefered_p.  If not set,
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index a1b638c..2630456 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -44,9 +44,7 @@
 #include "ada-lang.h"
 #include "completer.h"
 #include <sys/stat.h>
-#ifdef UI_OUT
 #include "ui-out.h"
-#endif
 #include "block.h"
 #include "infcall.h"
 #include "dictionary.h"
-- 
1.8.3.2


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]