This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64

On 12/23/13 17:18, Sergio Durigan Junior wrote:

On Monday, December 23 2013, Yufeng Zhang wrote:


Hi Sergio,


Hey Yufeng,


Thanks for the updated patch.  It looks OK to me and the only comment
I have is about the '$' character.  In A64, only '#' can be the
optional prefix for immediate.  I didn't see '$' checked in your
original patch; is there a particular reason that you added support
for '$' in this patch?


Thanks a lot.  You are right, only '#' is an optional prefix in
AArch64.  Here's an updated patch.
Thank you for your prompt action. It looks good to me. Please ask Tom (or other global maintainer) for an approval if you need to get it in today. 

Thanks,
Yufeng
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]