This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 3/9] add target method delegation
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Dec 2013 15:06:43 -0700
- Subject: Re: [PATCH v4 3/9] add target method delegation
- Authentication-results: sourceware.org; auth=none
- References: <1382464769-2465-1-git-send-email-tromey at redhat dot com> <1382464769-2465-4-git-send-email-tromey at redhat dot com> <526E8B54 dot 8040104 at redhat dot com> <87eh75cmig dot fsf at fleche dot redhat dot com> <87a9htcme3 dot fsf at fleche dot redhat dot com> <87habz7q6g dot fsf at fleche dot redhat dot com> <527D1A84 dot 9040106 at redhat dot com> <87lhzr11wz dot fsf at fleche dot redhat dot com> <87a9g623cw dot fsf at fleche dot redhat dot com> <871u1gz9q2 dot fsf at fleche dot redhat dot com> <52AEFB0A dot 3090104 at redhat dot com> <87r49cpk54 dot fsf at fleche dot redhat dot com> <52B078FA dot 8040004 at redhat dot com> <87d2kum2ri dot fsf at fleche dot redhat dot com>
Pedro> Yeah, not sure either... squash a few; post only the non-trivial
Pedro> ones as email; post all of them at once anyway; split in 4 or
Pedro> 5 batches. Whatever really is fine with me.
In case you want to see my progress, I've pushed the current branch to
my gitorious repository:
git@gitorious.org:binutils-gdb/gdb.git
The branch is "target-cleanup".
I've built the branch but barely tested it. I'm sure it breaks in some
configurations -- the fixes are trivial but I did have to do a number of
them as my refactoring script, while fun, could not perfectly fix
everything.
Aside from a few patches at the beginning of the series I think it's all
split and ordered pretty much as I'd like it to be.
I converted all the easy target methods to the new inheritance scheme.
This works out to be nearly all of them. There are a few more that
aren't too bad to convert (actually, looking again now I see I missed a
few more easy ones), and then a handful of tricky ones.
It's over the 200 patch mark... not sure I want to write those
ChangeLogs (my refactoring script only did the first 100 or so for
me...) or even re-read them all for sanity.
I hope you will agree that the result is much cleaner. It's simpler to
explain and understand; and it is obvious which model one ought to
choose when adding new target methods. It's also a good setup for the
multi-target work.
Tom