This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling
- From: Pedro Alves <palves at redhat dot com>
- To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Wed, 18 Dec 2013 16:24:22 +0000
- Subject: Re: [PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling
- Authentication-results: sourceware.org; auth=none
- References: <52B1C84F dot 4000102 at arm dot com>
On 12/18/2013 04:07 PM, Yufeng Zhang wrote:
> This patch fixes an AArch64 GDB bug in handling the hardware debug
> registers. GDB calls ptrace to set hardware debug registers and it
> passes a full-length "struct user_hwdebug_state" variable regardless of
> the number of hardware debug registers available on a target. When
> there are fewer than 16 (the maximum number) hardware
> breakpoint/watchpoint registers on a target, the kernel will complain
> about the gdb's request to set non-existing hardware debug registers.
> There will be an warning of "Unexpected error setting hardware debug
> registers" when the inferior starts to run.
>
> This patch fixes the issue by setting iov.iov_len with a value
> reflecting the exact size in use.
>
> OK for the mainline?
OK.
Thanks,
--
Pedro Alves