This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [Patch v2 02/10] type: add c99 variable length array support
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Tom Tromey' <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Boell, Keven" <keven dot boell at intel dot com>
- Date: Tue, 17 Dec 2013 12:13:52 +0000
- Subject: RE: [Patch v2 02/10] type: add c99 variable length array support
- Authentication-results: sourceware.org; auth=none
- References: <1385044223-24650-1-git-send-email-sanimir dot agovic at intel dot com> <1385044223-24650-3-git-send-email-sanimir dot agovic at intel dot com> <87y54g9nri dot fsf at fleche dot redhat dot com> <0377C58828D86C4588AEEC42FC3B85A7176CA040 at IRSMSX105 dot ger dot corp dot intel dot com> <87iouophos dot fsf at fleche dot redhat dot com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Tom Tromey
> Sent: Monday, December 16, 2013 11:14 PM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org; Boell, Keven
> Subject: Re: [Patch v2 02/10] type: add c99 variable length array support
>
> >>>>> "Sanimir" == Agovic, Sanimir <sanimir.agovic@intel.com> writes:
>
> Sanimir> In the prototype below I omit any call to copy_type_recursive,
> Sanimir> it works by selective re-constructing array and range types. As
> Sanimir> c99 vla are quite restrictive this works, but languages with
> Sanimir> less restrictive vla implementation (see Fortran vla branch)
> Sanimir> need to deep copy the type. Comments are welcome.
>
> For the Fortran changes you may want to introduce a new variant of
> copy_type_recursive that just copies the bits you need, and not all the
> extraneous stuff like strings.
>
Agreed, thanks Tom. The patch will be merged into my upcoming v4.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052