This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix for PR breakpoints/16297: Fix catch syscall to work with syscall 0
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Gabriel Krisman Bertazi <gabriel at krisman dot be>, gdb-patches at sourceware dot org
- Date: Mon, 16 Dec 2013 17:51:28 +0000
- Subject: Re: [PATCH] Fix for PR breakpoints/16297: Fix catch syscall to work with syscall 0
- Authentication-results: sourceware.org; auth=none
- References: <87fvpu4vgh dot fsf at lestat dot krisman dot be> <m3mwk24v5w dot fsf at redhat dot com>
On 12/15/2013 04:04 AM, Sergio Durigan Junior wrote:
> On Sunday, December 15 2013, Gabriel Krisman Bertazi wrote:
>
>> This is a fix for bug 16297. The problem occurs when the user attempts
>> to catch any syscall 0 (such as syscall read on Linux/x86_64). GDB was
>> not able to catch the syscall and was missing the breakpoint.
>>
>> Now, breakpoint_hit_catch_syscall returns immediately when it finds the
>> correct syscall number, avoiding a following check for the end of the
>> search vector, that returns a no hit if the syscall number was zero.
>
> Thanks.
>
> Just for the record, I pre-reviewed Krisman's patch and it's OK. I am
> also helping him in obtaining the copyright assignment.
Thanks you both. FAOD, this is OK.
> I will send a patch to test this feature as soon as my other patch
> (which touches catch-syscall.exp and improves it) gets approved.
--
Pedro Alves