This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 16 Dec 2013 17:12:51 +0000
- Subject: Re: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing
- Authentication-results: sourceware.org; auth=none
- References: <52ab8d0e dot 8aa2420a dot 30ff dot ffffd8f1SMTPIN_ADDED_BROKEN at mx dot google dot com>
On 12/13/2013 10:37 PM, Pierre Muller wrote:
> Following this thread
> https://sourceware.org/ml/gdb-patches/2013-12/msg00073.html
>
> The patch
> https://sourceware.org/ml/gdb-cvs/2013-12/msg00054.html
>
> introduced a failure for cygwin native build.
> The problem is that __USEWIDE is not considered in the patch.
>
> The patch below fixes this compilation error
> and should allow cygwin to work as mingw.
Looks fine to me.
(Though I wonder why not just use GetModuleFileNameExA
explicitly. In fact, it's what gdbserver does).
--
Pedro Alves