This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh


On Thursday 05 December 2013 14:48:12 Mark Kettenis wrote:
> > From: Tom Tromey <tromey@redhat.com>
> > Date: Thu, 05 Dec 2013 12:04:33 -0700
> > 
> > >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> > Pedro> A lot of this gdb.hp/ stuff is probably all rotten beyond
> > Pedro> salvation, but that's another story.
> > 
> > Yeah, it's never run by any regular developers since all the .exp files
> > start:
> > 
> > if { ![istarget "hppa*-*-hpux*"] } {
> > 
> >     verbose "HPUX test ignored for non-hppa targets."
> >     return 0
> > 
> > }
> 
> And /bin/sh on HP-UX is pretty crappy.  If you want anything
> resembling a POSIX shell /bin/ksh was a much better choice.
> 
> I'd suggest to leave these test alone or remove them altogether.

how crappy is it really though ?  if you look at the scripts, they are dirt 
simple.  symaddr runs a single command in a pipeline and uses positional 
parameters ($1).

so-thresh.sh has two simple if statements and custom variables and that's it.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]