This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Delegate to target_ops->beneath to read cache lines

From: Pedro Alves <palves at redhat dot com>
To: Doug Evans <xdje42 at gmail dot com>
Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Fri, 29 Nov 2013 19:59:43 +0000
Subject: Re: [PATCH] Delegate to target_ops->beneath to read cache lines
Authentication-results: sourceware.org; auth=none
References: <1385554824-7159-1-git-send-email-yao at codesourcery dot com> <5295F877 dot 3060004 at redhat dot com> <52980180 dot 1050000 at codesourcery dot com> <CAP9bCMTpcUJ_Okp8XwBhCQefsKrfkUo4iKcrv8B_Xip4Hc+h8w at mail dot gmail dot com>

On 11/29/2013 07:42 PM, Doug Evans wrote:
> I think a comment is required here explaining why things are the way they are.
> i.e., why we use current_target.beneath instead of &current_target.

I suggest adding a target_read_raw_memory function, similar,
and next to target_read_memory, target_read_stack, etc., and
put the comment there.  Incidentally, I notice target_read_code
misses the comment.

-- 
Pedro Alves

References:
- [PATCH] Delegate to target_ops->beneath to read cache lines
  - From: Yao Qi
- Re: [PATCH] Delegate to target_ops->beneath to read cache lines
  - From: Pedro Alves
- Re: [PATCH] Delegate to target_ops->beneath to read cache lines
  - From: Yao Qi
- Re: [PATCH] Delegate to target_ops->beneath to read cache lines
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]