This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] update comment in dw2-bad-cfi.S.


Pedro asked me to add a comment to dw2-bad-cfi.S explaining the nature
of the badness.

I'm checking this in.

2013-11-22  Tom Tromey  <tromey@redhat.com>

	* gdb.dwarf2/dw2-bad-cfi.S: Update comment.
---
 gdb/testsuite/ChangeLog                | 4 ++++
 gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S b/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S
index 9a97889..ab3a967 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S
@@ -26,7 +26,8 @@ callee:
 	.loc 1 21 0
 	popq	%rbp
 /*	.cfi_def_cfa 7, 8 */
-	# Our little lies.
+	/* The bug we introduce is that the return address column is
+	   unspecified.  In this case, there is no way to unwind.  */
 	.cfi_undefined 6
 	.cfi_return_column 6
 # SUCC: EXIT [100.0%] 
-- 
1.8.1.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]