This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 15520 - GDB step command crashed on non-stop mode


>>>>> ">" == Muhammad Waqas <mwaqas@codesourcery.com> writes:

>> 2013-09-13  Muhammad Waqas  <mwaqas@codesourcery.com>

>> 	PR 15520

It's more usual to use the component in here as well.
I'm not sure whether the commit script's regex will match the above.
So it would be:

	PR threads/15520

>> 	*gdb.base/pr15520.cc: New file.
>> 	*gdb.base/pr15520.exp: New file.

Two notes here.

First, space after the "*".

Second, we generally don't use the PR number in the test case file names.
Instead we try to use a descriptive name.

I don't fully understand the fix itself.
Maybe you could walk me through it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]