This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/5] infrun.c:handle_inferior_event: Remove some more dead code.


Pedro Alves wrote:
> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index 4f7068c..8b1b668 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -3120,17 +3120,6 @@ handle_syscall_event (struct execution_control_state *ecs)
>    return 1;
>  }
>  
> -/* Clear the supplied execution_control_state's stop_func_* fields.  */
> -
> -static void
> -clear_stop_func (struct execution_control_state *ecs)
> -{
> -  ecs->stop_func_filled_in = 0;
> -  ecs->stop_func_start = 0;
> -  ecs->stop_func_end = 0;
> -  ecs->stop_func_name = NULL;
> -}
> -

I added this one a couple of years ago:

  https://sourceware.org/ml/gdb-patches/2011-07/msg00460.html

I think the reason I put that stuff in a separate function was
as a partner function to fill_in_stop_func introduced in the
same commit.  I didn't think to check whether the clears were
necessary, so good catch :)

Cheers,
Gary

-- 
http://gbenson.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]