This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 21 Oct 2013 09:47:02 -0700
- Subject: Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound
- Authentication-results: sourceware.org; auth=none
- References: <1382032193-9115-1-git-send-email-tromey at redhat dot com> <1382032193-9115-2-git-send-email-tromey at redhat dot com> <CADPb22REQv7uCG3eHAR5SSgVqkkPtRuk_0Kbevc7Fz8aU4OeLg at mail dot gmail dot com> <8738nulhjf dot fsf at fleche dot redhat dot com>
On Mon, Oct 21, 2013 at 9:23 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> When I read the comment "Try ..." I'm left with asking "What if the
> Doug> attempt fails?".
> Doug> Maybe remove the words "Try to" and be clearer about what the result
> Doug> is if a heuristic is needed?
>
> I changed it to read:
>
> /* Compute the upper bound of MINSYM. The upper bound is the last
> address thought to be part of the symbol. If the symbol has a
> size, it is used. Otherwise use the lesser of the next minimal
> symbol in the same section, or the end of the section, as the end
> of the function. */
>
> Let me know what you think.
LGTM