This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] regcache, use print_hex_chars
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 23 Sep 2013 12:53:09 +0100
- Subject: [PATCH] regcache, use print_hex_chars
- Authentication-results: sourceware.org; auth=none
Another place we reimplement print_hex_chars, again I'll commit as obvious in a few days if nobody objects.
Thanks,
Andrew
gdb/ChangeLog
2013-09-23 Andrew Burgess <aburgess@broadcom.com>
* regcache.c: Add include of valprint.h.
(dump_endian_bytes): Delete.
(regcache_dump): Use print_hex_chars not dump_endian_bytes.
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 57d29e4..7ec75c8 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -30,6 +30,7 @@
#include "observer.h"
#include "exceptions.h"
#include "remote.h"
+#include "valprint.h"
/*
* DATA STRUCTURE
@@ -1090,27 +1091,6 @@ reg_flush_command (char *command, int from_tty)
printf_filtered (_("Register cache flushed.\n"));
}
-static void
-dump_endian_bytes (struct ui_file *file, enum bfd_endian endian,
- const gdb_byte *buf, long len)
-{
- int i;
-
- switch (endian)
- {
- case BFD_ENDIAN_BIG:
- for (i = 0; i < len; i++)
- fprintf_unfiltered (file, "%02x", buf[i]);
- break;
- case BFD_ENDIAN_LITTLE:
- for (i = len - 1; i >= 0; i--)
- fprintf_unfiltered (file, "%02x", buf[i]);
- break;
- default:
- internal_error (__FILE__, __LINE__, _("Bad switch"));
- }
-}
-
enum regcache_dump_what
{
regcache_dump_none, regcache_dump_raw,
@@ -1258,10 +1238,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file,
else
{
regcache_raw_read (regcache, regnum, buf);
- fprintf_unfiltered (file, "0x");
- dump_endian_bytes (file,
- gdbarch_byte_order (gdbarch), buf,
- regcache->descr->sizeof_register[regnum]);
+ print_hex_chars (file, buf,
+ regcache->descr->sizeof_register[regnum],
+ gdbarch_byte_order (gdbarch));
}
}
@@ -1280,12 +1259,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file,
else if (status == REG_UNAVAILABLE)
fprintf_unfiltered (file, "<unavailable>");
else
- {
- fprintf_unfiltered (file, "0x");
- dump_endian_bytes (file,
- gdbarch_byte_order (gdbarch), buf,
- regcache->descr->sizeof_register[regnum]);
- }
+ print_hex_chars (file, buf,
+ regcache->descr->sizeof_register[regnum],
+ gdbarch_byte_order (gdbarch));
}
}