This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix compilation error in readline/util.c in environments with missing strcasecmp
- From: Joel Brobecker <brobecker at adacore dot com>
- To: bug-readline at gnu dot org
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Martin Benda <martin dot benda at omsquare dot com>
- Date: Sat, 21 Sep 2013 06:48:37 -0700
- Subject: Re: [PATCH] Fix compilation error in readline/util.c in environments with missing strcasecmp
- Authentication-results: sourceware.org; auth=none
- References: <04BF4C19-304E-4CEB-964B-06CEF63E3DCC at omsquare dot com>
Hi Chet,
Martin just sent us this patch, which indedd looks trivial, but we
thought we'd run it by you first so you could apply it in the official
repository first if you agree. On our end, we'll apply the fix you
decide to apply.
Thank you both!
> when building GDB 7.6.1 in MinGW (Windows 7) for the arm-none-eabi
> target, I got compilation error in readline/util.c:392 --- missing
> semicolon after do { ... } while (...) loop. The attached patch fixes
> this trivial error.
>
>
> 2013-09-21 Martin Benda <martin.benda@omsquare.com>
>
> * readline/util.c: Add missing semicolon to fix compilation error
> in environments with missing strcasecmp (e.g. MinGW).
>
>
> diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c
> --- gdb-7.6.1/readline/util.c 2013-09-21 09:28:03.000000000 +0200
> +++ gdb-7.6.1-patched/readline/util.c 2013-09-21 09:41:12.000000000 +0200
> @@ -389,7 +389,7 @@
> break;
> s2++;
> }
> - while (--count != 0)
> + while (--count != 0);
>
> return (0);
> }
>
>
> Martin Benda
> diff -Naur gdb-7.6.1/readline/util.c dist-patched/gdb-7.6.1/readline/util.c
> --- gdb-7.6.1/readline/util.c 2013-09-21 09:28:03.000000000 +0200
> +++ gdb-7.6.1-patched/readline/util.c 2013-09-21 09:41:12.000000000 +0200
> @@ -389,7 +389,7 @@
> break;
> s2++;
> }
> - while (--count != 0)
> + while (--count != 0);
>
> return (0);
> }
> 2013-09-21 Martin Benda <martin.benda@omsquare.com>
>
> * readline/util.c: Add missing semicolon to fix compilation error
> in environments with missing strcasecmp (e.g. MinGW).
--
Joel