This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf


Yao Qi writes:
 > When we add performance tests, we think typical 'make check' should
 > not run performance tests.  We add a new makefile target 'check-perf'
 > to run performance test only.
 > 
 > We also add a new dir gdb.perf in testsuite for all performance tests.
 > However, current 'make check' logic will either run dejagnu in
 > directory testsuite or iterate all gdb.* directories which has *.exp
 > files.  Both of them will run tests in gdb.perf, so we have to filter
 > gdb.perf out.  In makefile target 'check-single', we pass a list of
 > gdb.* directories except gdb.perf.  We also update $(TEST_DIRS) to
 > filter out gdb.perf too, so that tests in gdb.perf can't be run in
 > target check-parallel.

An alternative is as Tom suggests, do something like
"if [skip_perf_tests] ..." at the top of each perf.exp file.

That has the flair consistency, but I'm not sure which I like better,
though I do like consistency.

Thoughts?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]