This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Test case for entry values.
- From: Vidya Praveen <vidyapraveen at arm dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 11 Sep 2013 14:27:33 +0100
- Subject: Re: [PATCH 1/2] Test case for entry values.
- Authentication-results: sourceware.org; auth=none
- References: <1376379586-24150-1-git-send-email-yao at codesourcery dot com> <1376379586-24150-2-git-send-email-yao at codesourcery dot com> <5220B1B6 dot 2000304 at arm dot com> <20130830152927 dot GC9666 at e103625-lin dot cambridge dot arm dot com> <52213712 dot 1030700 at codesourcery dot com> <20130910153019 dot GA2535 at e103625-lin dot cambridge dot arm dot com> <522FAE9C dot 2000206 at codesourcery dot com>
On Wed, Sep 11, 2013 at 12:43:24AM +0100, Yao Qi wrote:
> On 09/10/2013 11:30 PM, Vidya Praveen wrote:
> > OK. But isn't it better to have the condition (!gdb_target_supports_trace)
> > that checks if the target supports tracing, in the beginning of the test
> > rather than much later?
>
> This part of test is about testing entry values, and the bottom part
> (added by patch 2/2) is about testing unavailable entry values when
> examining trace frames. This part is not related to tracing, so we
> can't use gdb_target_supports_trace to check.
>
> See my description in "PATCH 0/2"
>
> > Patch 1/2 is to generate dwarf using Dwarf Assembler to test "entry values"
> > are shown correctly. At this point, gdb.trace/entry-values.exp is still
> > a dwarf test, nothing to do with trace. Patch 2/2 is to use tracepoint,
> > to collect data, to test what happen when argument is available and entry
> > value is not.
>
> https://sourceware.org/ml/gdb-patches/2013-08/msg00327.html
However, it scans for the 'call' instruction regardless of the target. Though
your comment explains it, the test is still target specific. It should check
for the target before scanning for 'call' and not assume the $sp for all
targets except for those you already check.
Regards
VP