This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Remove deprecated_command_loop_hook
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 5 Sep 2013 17:04:31 +0100
- Subject: [PATCH] Remove deprecated_command_loop_hook
- Authentication-results: sourceware.org; auth=none
With these two patches having been committed:
https://sourceware.org/ml/gdb-patches/2013-08/msg00872.html
https://sourceware.org/ml/insight/2013-q3/msg00029.html
deprecated_command_loop_hook is no longer used.
This patch removes it.
OK to apply?
Thanks,
Andrew
2013-09-05 Andrew Burgess <aburgess@broadcom.com>
* gdb/defs.h (deprecated_command_loop_hook): Remove, including
references in comments.
* gdb/interps.c (current_interp_command_loop): No longer use
deprecated_command_loop_hook.
(clear_interpreter_hooks): Remove deprecated_command_loop_hook
setup.
* gdb/top.c (deprecated_command_loop_hook): Remove.
diff --git a/gdb/defs.h b/gdb/defs.h
index 1e5521f..50b9bfe 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -703,10 +703,8 @@ extern int watchdog;
extern char *interpreter_p;
/* If a given interpreter matches INTERPRETER_P then it should update
- deprecated_command_loop_hook and deprecated_init_ui_hook with the
- per-interpreter implementation. */
-/* FIXME: deprecated_command_loop_hook and deprecated_init_ui_hook
- should be moved here. */
+ deprecated_init_ui_hook with the per-interpreter implementation. */
+/* FIXME: deprecated_init_ui_hook should be moved here. */
struct target_waitstatus;
struct cmd_list_element;
@@ -716,7 +714,6 @@ extern void (*deprecated_post_add_symbol_hook) (void);
extern void (*selected_frame_level_changed_hook) (int);
extern int (*deprecated_ui_loop_hook) (int signo);
extern void (*deprecated_init_ui_hook) (char *argv0);
-extern void (*deprecated_command_loop_hook) (void);
extern void (*deprecated_show_load_progress) (const char *section,
unsigned long section_sent,
unsigned long section_size,
diff --git a/gdb/interps.c b/gdb/interps.c
index 25500d6..33e0f72 100644
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -320,12 +320,9 @@ void
current_interp_command_loop (void)
{
/* Somewhat messy. For the moment prop up all the old ways of
- selecting the command loop. `deprecated_command_loop_hook'
- should be deprecated. */
- if (deprecated_command_loop_hook != NULL)
- deprecated_command_loop_hook ();
- else if (current_interpreter != NULL
- && current_interpreter->procs->command_loop_proc != NULL)
+ selecting the command loop. */
+ if (current_interpreter != NULL
+ && current_interpreter->procs->command_loop_proc != NULL)
current_interpreter->procs->command_loop_proc (current_interpreter->data);
else
cli_command_loop ();
@@ -386,7 +383,6 @@ clear_interpreter_hooks (void)
deprecated_target_wait_hook = 0;
deprecated_call_command_hook = 0;
deprecated_error_begin_hook = 0;
- deprecated_command_loop_hook = 0;
}
/* This is a lazy init routine, called the first time the interpreter
diff --git a/gdb/top.c b/gdb/top.c
index bb71263..b3e7d37 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -199,11 +199,6 @@ void (*deprecated_init_ui_hook) (char *argv0);
int (*deprecated_ui_loop_hook) (int);
-/* Called instead of command_loop at top level. Can be invoked via
- throw_exception(). */
-
-void (*deprecated_command_loop_hook) (void);
-
/* Called from print_frame_info to list the line we stopped in. */