Re: [PATCH] switch to fully parallel mode

[Yao Qi <yao at codesourcery dot com>]

On 08/29/2013 01:36 AM, Tom Tromey wrote:
> +# Turn a list of .exp files into "check/" targets.  Only examine .exp
> +# files appearing in a gdb.* directory -- we don't want to pick up
> +# lib/ by mistake.  For example, gdb.linespec/linespec.exp becomes
> +# check/gdb.linespec/linespec.exp.  The list is generally sorted
> +# alphabetically, but we take a few tests known to be slow and push
> +# them to the front of the list to try to lessen the overall time
> +# taken by the test suite -- if one of these tests happens to be run
> +# late, it will cause the overall time to increase.
> +slow_tests = gdb.base/break-interp.exp gdb.base/interp.exp \
> +	gdb.base/multi-forks.exp

I am not sure we should consider slow_tests in this patch.  This patch
is about running testsuite in parallel.  The minor tuning can be
addressed separately, or is it really necessary to do that?  "Code is
simple, but slower to run" is acceptable to me, given that testing in
parallel is fast enough.

> +@GMAKE_TRUE@all_tests := $(shell cd $(srcdir) && find gdb.* -name '*.exp' -print)

I am fine to get all tests by 'find' as long as it is easy to exclude a
directory in the future.  I am proposing to add a directory 'gdb.perf'
in testsuite, and we can exclude it here then.

> +@GMAKE_TRUE@reordered_tests := $(slow_tests) $(filter-out $(slow_tests),$(all_tests))
> +@GMAKE_TRUE@TEST_TARGETS := $(addprefix check/,$(reordered_tests))
> +

Is TEST_TARGETS defined when using non-gnu make?

> +do-check-parallel: $(TEST_TARGETS)
> +	@:


--
Yao (éå)