This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch gdbserver 7.6.1 only] Fix fd leak regression


On 08/29/2013 03:40 PM, Tom Tromey wrote:
>>> * There is no real need for SOCK_CLOEXEC, GDB benefits from it for Python
>>> threads (possibly calling their own fork+exec) but those do not happen for
>>> gdbserver.
> 
> Pedro> I suspect we'll have to revisit this at some point (years from now),
> Pedro> but yeah, agreed.
> 
> gdbserver on trunk can just use the filestuff.c code.

Yeah, it already does:

 https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html

but it doesn't call socket_mark_cloexec or similars, so we'll
probably still have to revisit this at some point (years
from now).  :-)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]