This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch gdbserver 7.6.1 only] Fix fd leak regression
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 29 Aug 2013 15:50:57 +0100
- Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression
- Authentication-results: sourceware.org; auth=none
- References: <20130829111053 dot GA25662 at host2 dot jankratochvil dot net> <521F3B71 dot 1010007 at redhat dot com> <20130829130359 dot GA31063 at host2 dot jankratochvil dot net> <521F5804 dot 1080604 at redhat dot com> <87a9k0sgpf dot fsf at fleche dot redhat dot com>
On 08/29/2013 03:40 PM, Tom Tromey wrote:
>>> * There is no real need for SOCK_CLOEXEC, GDB benefits from it for Python
>>> threads (possibly calling their own fork+exec) but those do not happen for
>>> gdbserver.
>
> Pedro> I suspect we'll have to revisit this at some point (years from now),
> Pedro> but yeah, agreed.
>
> gdbserver on trunk can just use the filestuff.c code.
Yeah, it already does:
https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html
but it doesn't call socket_mark_cloexec or similars, so we'll
probably still have to revisit this at some point (years
from now). :-)
--
Pedro Alves