This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectures.
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Will Newton' <will dot newton at linaro dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "patches at linaro dot org" <patches at linaro dot org>
- Date: Mon, 26 Aug 2013 14:01:57 +0000
- Subject: RE: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectures.
- Authentication-results: sourceware.org; auth=none
- References: <52190AAD dot 2050901 at linaro dot org>
Hello Will,
I run your fix via buildbot[1] and now all builds are green again, thus it lgtm.
However I cannot approve your patch.
[1] http://gcc20.fsffrance.org:9010/waterfall
-Sanimir
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Will Newton
> Sent: Saturday, August 24, 2013 09:34 PM
> To: gdb-patches@sourceware.org
> Cc: patches@linaro.org
> Subject: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectures.
>
>
> As uintptr_t is used stdint.h must be included on all architectures.
>
> 2013-08-24 Will Newton <will.newton@linaro.org>
>
> * common/linux-ptrace.c: Include stdint.h unconditionally.
> ---
> gdb/common/linux-ptrace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/common/linux-ptrace.c b/gdb/common/linux-ptrace.c
> index a4a2ca3..3a8e25e 100644
> --- a/gdb/common/linux-ptrace.c
> +++ b/gdb/common/linux-ptrace.c
> @@ -30,6 +30,8 @@
> #include "gdb_assert.h"
> #include "gdb_wait.h"
>
> +#include <stdint.h>
> +
> /* Stores the currently supported ptrace options. A value of
> -1 means we did not check for features yet. A value of 0 means
> there are no supported features. */
> @@ -64,7 +66,6 @@ extern void (linux_ptrace_test_ret_to_nx_instr) (void);
> #include <sys/reg.h>
> #include <sys/mman.h>
> #include <signal.h>
> -#include <stdint.h>
>
> #endif /* defined __i386__ || defined __x86_64__ */
>
> --
> 1.8.1.4
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052