This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix PR-15501
- From: Pedro Alves <palves at redhat dot com>
- To: "Waqas, Muhammad" <Muhammad_Waqas at mentor dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 22 Aug 2013 14:41:25 +0100
- Subject: Re: [PATCH] fix PR-15501
- References: <520A0453 dot 4070309 at codesourcery dot com> <520A6EEB dot 8010808 at redhat dot com> <520CAE24 dot 7050301 at codesourcery dot com>,<52153C74 dot 7080708 at redhat dot com> <53A5AC689E2AD547AE0EA5642E101306BB6120 at EU-MBX-04 dot mgc dot mentorg dot com>,<5215FDBE dot 1060209 at redhat dot com> <53A5AC689E2AD547AE0EA5642E101306BB63F5 at EU-MBX-04 dot mgc dot mentorg dot com>
On 08/22/2013 02:13 PM, Waqas, Muhammad wrote:
> +# Perform tests for disable/enable commands on multiple
> +# locations and breakpoints.
> +#
> +# WHAT - the command to test (disable/enable).
That extra whitespace after WHAT was there before to align
with the other arguments. There are no other arguments now,
so write:
# WHAT - the command to test (disable/enable).
> + if { "$what" == "enable" } {
> + # Set variable values for enable command.
> + set oppos "disable"
> + set oppos_res "n"
> + set what_res "y"
> + set p1 "fail"
> + set p2 "pass"
> +
Spurious extra line.
> + }
> +
> + # Now enable(disable) $b.1 $b2.1.
> + gdb_test_no_output "$what $b1.1 $b2.1" "$what \$b1.1 \$b2.1"
> + set test1 "${what}d \$b1.1 and \$b2.1"
> +
> + # Now $b1.1 and $b2.1 should be enabled(disabled)
Missing period. (Most other sentences had it.)
> +
> + # Now $b4 $b3.1 should be enabled(disabled) and
> + # $b3 should remain disabled(enabled)
Ditto.
OK with those changes. Thanks!
As the final patch will have changes, please commit, and
still repost it.
--
Pedro Alves