This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Windows x64 SEH unwinder


Hi Tristan...

gdb-patches-owner@sourceware.org wrote on 22.08.2013 11:33:10:
> Hello,
>
> after discussion with Roland Schwingel, I have found that the patch
> doesn't handle well dwarf3 DW_OP_call_frame_cfa, because the SEH
> unwinder is before the dwarf2 one.
>
> So I propose this new patch.  The only change is the position of the
> SEH unwinder: it is appended after the dwarf2 one.
> As a consequence, old binaries should work too.
I just gave your new patch a brief trial with my gcc 4.8.2. I can confirm that unwinding now works as it should. I tried it with both
-g and -gdwarf-2 in gcc 4.8.2.

Thank your very much! This finally fixes my 8 years old issue.
(see http://sourceware.org/ml/gdb/2005-04/msg00113.html)

When an application crashes on windows I can see the the stack trace again (as it has been with gdb 5.3 in the past). Variable inspection with your v3 patch is also now working. No more errors.

SEH unwinding only works for 64bit but this is perfectly ok for me as I am fully 64bit for quite a while now!

IMHO I would say ok to commit :-)

This is IMHO a killer feature for the next gdb...

Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]