This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix for PR15117
- From: Tom Tromey <tromey at redhat dot com>
- To: ali_anwar <ali_anwar at codesourcery dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 07 Aug 2013 14:01:10 -0600
- Subject: Re: [PATCH] Fix for PR15117
- References: <51F7EFF1 dot 6030609 at codesourcery dot com> <51F80C61 dot 9080308 at redhat dot com> <51FBA2A6 dot 8000307 at codesourcery dot com> <51FBF127 dot 7000108 at redhat dot com> <5201DE39 dot 6060302 at codesourcery dot com>
>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
Ali> Thank you for reviewing the patch again.
It's customary to always send the ChangeLog entry when re-sending a
patch.
I personally do this by putting the ChangeLog entry into the git commit
and using git send-email, but there are many ways to manage it.
The patch is ok with the ChangeLog from up-thread.
FWIW I am not especially fond of convenience variables in linespecs.
They seem odd to me. Like, won't the breakpoint move at re-set if the
variable changes? Also I note that they aren't documented... But your
patch is just fixing an error in the existing support, which I think
makes it ok to go in.
thanks,
Tom