This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/4] add caching procs to test suite
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 02 Aug 2013 18:23:30 +0100
- Subject: Re: [PATCH v2 3/4] add caching procs to test suite
- References: <1375457773-863-1-git-send-email-tromey at redhat dot com> <1375457773-863-4-git-send-email-tromey at redhat dot com> <51FBD5E2 dot 5000707 at redhat dot com> <8738qsdoo3 dot fsf at fleche dot redhat dot com>
On 08/02/2013 05:48 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 08/02/2013 04:36 PM, Tom Tromey wrote:
>>> - set src complex[pid].c
>>> - set exe complex[pid].x
>>> + set src [standard_temp_file complex[pid].c]
>>> + set exe [standard_temp_file complex[pid].x]
>
> Pedro> Hmm. Are these uses of standard_temp_file really
> Pedro> related to the caching mechanism?
>
> Not really. I can push them into patch 2 if you want.
I always prefer logically independent changes split into
independent patches, as it makes it much easier to
understand a patch and its ramifications (post-checkin too, when
doing archaelogy and regression culprit finding), but I don't
want to insist.
--
Pedro Alves