This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Update pattern to match when value is missing


Hi,
I get some fails when I test mingw native gdb,

> -var-create endvar * _end
^error,msg="mi_cmd_var_create: unable to create variable object"
(gdb)
FAIL: gdb.mi/mi-var-cmd.exp: create endvar

The test was added by this patch,

  [mi] Some error path fixes
  http://sourceware.org/ml/gdb-patches/2006-12/msg00107.html

and at that point, the error message was like:

-var-create endvar * _end
&"mi_cmd_var_create: unable to create variable object\n"
^error,msg="mi_cmd_var_create: unable to create variable object"
-var-update endvar
&"Variable object not found\n"
^error,msg="Variable object not found"
-var-delete endvar
&"Variable object not found\n"
^error,msg="Variable object not found"

and the pattern in the test matches them.  As time goes by, we updated
the error message,

-var-create endvar * _end^M
^error,msg="-var-create: unable to create variable object"
-var-update endvar^M
^error,msg="Variable object not found"
-var-delete endvar^M
^error,msg="Variable object not found"

but forget to update the pattern, so we get these three fails.

FAIL: gdb.mi/mi-var-cmd.exp: create endvar
FAIL: gdb.mi/mi-var-cmd.exp: update endvar
FAIL: gdb.mi/mi-var-cmd.exp: delete endvar

This patch is to adjust the pattern to match current error message,
and fix these three fails accordingly.  OK?

gdb/testsuite:

2013-07-22  Yao Qi  <yao@codesourcery.com>

	* gdb.mi/mi-var-cmd.exp: Adjust pattern to match current error
	message.
---
 gdb/testsuite/gdb.mi/mi-var-cmd.exp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-var-cmd.exp b/gdb/testsuite/gdb.mi/mi-var-cmd.exp
index 6addea6..00dc0df 100644
--- a/gdb/testsuite/gdb.mi/mi-var-cmd.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-cmd.exp
@@ -621,17 +621,17 @@ mi_gdb_test "kill" \
     "kill program before endvar"
 
 mi_gdb_test "-var-create endvar * _end" \
-    {(\^done,name="endvar",numchild="0",value=".*",type=".*"|&".*unable to.*".*\^error,msg=".*")} \
+    {(\^done,name="endvar",numchild="0",value=".*",type=".*"|\^error,msg=".*")} \
     "create endvar"
 
 # Allow this to succeed whether the value is readable, unreadable, or
 # missing.  Most important is that GDB does not crash.
 mi_gdb_test "-var-update endvar" \
-    {(\^done,changelist=\[.*\]|^".*".*\^error,msg=".*not found")} \
+    {(\^done,changelist=\[.*\]|\^error,msg=".*not found")} \
     "update endvar"
 
 mi_gdb_test "-var-delete endvar" \
-    "\\^done,ndeleted=\"1\"" \
+    {(\^done,ndeleted="1"|\^error,msg=".*not found")} \
     "delete endvar"
 
 mi_delete_breakpoints
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]