This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/5] powerpc64-aix- Processing XLC generated line tables


>>>>> ">" == Raunaq 12 <raunaq12@in.ibm.com> writes:

>> powerpc-ibm-aix: Fix line number handling for xlc compiled binaries.
>> xlc compiled binaries have a line table which is different from gcc
>> compiled ones.
>> It does not contain 1 extra entry which indicates the function start PC.

Your patch got line-wrapped by your mailer, making it hard to read.

Also you should send a ChangeLog entry with a patch.
See the gdb contribution instructions in gdb/CONTRIBUTE.

>> +              if (lineTb->item[jj].line == 0 && (lineTb->item[jj].pc !=
lineTb-> item[jj+1].pc))

I think this line is too long.
Also it is not formatted properly... no space after "->", but spaces
required around "+".

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]