This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Jun 2013 18:24:57 +0100
- Subject: Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- References: <1371835506-15691-1-git-send-email-tromey at redhat dot com> <1371835506-15691-12-git-send-email-tromey at redhat dot com>
On 06/21/2013 06:25 PM, Tom Tromey wrote:
> This moves a few static variables out of remote_read_qxfer and into
> remote_state. It is unclear to me if this data can ever be required
> to be kept around across a potential target switch, but it is
> definitely safe to move it into the remote state object.
It's a cache, so we can always discard and refetch the data
it if switching targets discarded it. But this is definitely
per-target/connection data, so putting in remote_state is a better choice.
Thanks,
--
Pedro Alves