This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Fri, 21 Jun 2013 08:51:17 -0700
- Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
- References: <1369881867-11372-1-git-send-email-yao at codesourcery dot com> <1369881867-11372-3-git-send-email-yao at codesourcery dot com> <51B93F00 dot 5090002 at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1306171650220 dot 16287 at tp dot orcam dot me dot uk> <51C305F0 dot 90008 at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1306201624110 dot 16287 at tp dot orcam dot me dot uk> <20130620172844 dot GE4724 at adacore dot com> <alpine dot DEB dot 1 dot 10 dot 1306202201290 dot 16287 at tp dot orcam dot me dot uk>
> FWIW and IMHO.
What you say makes sense to me, and I would agree to an update.
I do think that we should try to standardize to a minimum number
of lengths. For new, we have two kinds of "text":
- Documentation/comments
- Code
I'd agree to 78 or 79 for code, and I've often found that the extra
length would allow a statement to fit on fewer lines, looking and
reading better. I would add that I've always felt that 70 was a soft
limit, and that people should feel free to extend when needed.
For documentation, I would have stayed with 70, except that ChangeLog
files can be considered code. I'm wondering if we could try 74 instead.
FWIW and IMHO as well :). The problem with those types of discussions
that people tend to discuss them a lot, but then it's hard to actually
make any decision. I'll say I'm flexible - and actually have been
already wrt past code reviews. I think of this "rule" more as a
guideline, rather than a hard rule.
--
Joel