This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] gdb/testsuite/gdb.dwarf2: Replaces @ with % sign to allow tests stay compatible with both arm and x86 assembly


Hi Omair,

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Omair Javaid
> Sent: 10 June 2013 02:18
> To: gdb-patches@sourceware.org
> Subject: [PATCH] gdb/testsuite/gdb.dwarf2: Replaces @ with % sign to allow
> tests stay compatible with both arm and x86 assembly
> 
> ARM assembler recognise @ symbol as a comment marker and therefore is
> unable to assemble some of gdb.dwarf2 testsuite tests. This patch replaces
> all occurrences of @ symbol with % sign to allow tests stay compatible with
> both arm and x86 assembly. This patch has been tested on x86_64 and
> armv7 targets.
> 
> gdb/testsuite/ChangeLog:
> 
> 2013-06-10  Omair Javaid  <Omair.Javaid@linaro.org>
> 
>         * gdb.dwarf2/fission-reread.S: Replace @ sign with % sign to remove
>         assembler errors on arm.
>         * gdb.dwarf2/mac-fileno.S: Likewise
>         * gdb.dwarf2/member-ptr-forwardref.S: Likewise
>         * gdb.dwarf2/pr13961.S: Likewise
Just a small nit. Please indent ChangeLog with tab. Also in ChangeLog, you describe what was changed and not why was it changed. So "to remove assembler errors on arm" above may be unnecessary.

Regards,
Abid


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]